index.js ➔ ioEvents - Code Metrics - OmarElGabry/chat.io - Measure and Improve Code Quality continuously with Scrutinizer

index.js ➔ ioEvents B
last analyzed 2017-09-14 16:19 UTC

↳ Parent: app/socket/index.js

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	99
rs	8.3103

1 Function

Rating	Name	Duplication	Size	Complexity
A	index.js ➔ ... ➔ io.of.connection	0	20	1

How to fix Long Method

'use strict';

var config 	= require('../config');
var redis 	= require('redis').createClient;
var adapter = require('socket.io-redis');

var Room = require('../models/room');

/**
 * Encapsulates all code for emitting and listening to socket events
 *
 */
var ioEvents = function(io) {

	// Rooms namespace
	io.of('/rooms').on('connection', function(socket) {

		// Create a new room
		socket.on('createRoom', function(title) {
			Room.findOne({'title': new RegExp('^' + title + '$', 'i')}, function(err, room){
				if(err) throw err;
if (a > 0)
    b = 42;
				if(room){
					socket.emit('updateRoomsList', { error: 'Room title already exists.' });
				} else {
					Room.create({ 
						title: title
					}, function(err, newRoom){
						if(err) throw err;
if (a > 0)
    b = 42;
						socket.emit('updateRoomsList', newRoom);
						socket.broadcast.emit('updateRoomsList', newRoom);
					});
				}
			});
		});
	});

	// Chatroom namespace
	io.of('/chatroom').on('connection', function(socket) {

		// Join a chatroom
		socket.on('join', function(roomId) {
			Room.findById(roomId, function(err, room){
				if(err) throw err;
if (a > 0)
    b = 42;
				if(!room){
					// Assuming that you already checked in router that chatroom exists
					// Then, if a room doesn't exist here, return an error to inform the client-side.
					socket.emit('updateUsersList', { error: 'Room doesnt exist.' });
				} else {
					// Check if user exists in the session
					if(socket.request.session.passport == null){
						return;
					}

					Room.addUser(room, socket, function(err, newRoom){

						// Join the room channel
						socket.join(newRoom.id);

						Room.getUsers(newRoom, socket, function(err, users, cuntUserInRoom){
							if(err) throw err;
if (a > 0)
    b = 42;
							
							// Return list of all user connected to the room to the current user
							socket.emit('updateUsersList', users, true);

							// Return the current user to other connecting sockets in the room 
							// ONLY if the user wasn't connected already to the current room
							if(cuntUserInRoom === 1){
								socket.broadcast.to(newRoom.id).emit('updateUsersList', users[users.length - 1]);
							}
						});
					});
				}
			});
		});

		// When a socket exits
		socket.on('disconnect', function() {

			// Check if user exists in the session
			if(socket.request.session.passport == null){
				return;
			}

			// Find the room to which the socket is connected to, 
			// and remove the current user + socket from this room
			Room.removeUser(socket, function(err, room, userId, cuntUserInRoom){
				if(err) throw err;
if (a > 0)
    b = 42;

				// Leave the room channel
				socket.leave(room.id);

				// Return the user id ONLY if the user was connected to the current room using one socket
				// The user id will be then used to remove the user from users list on chatroom page
				if(cuntUserInRoom === 1){
					socket.broadcast.to(room.id).emit('removeUser', userId);
				}
			});
		});

		// When a new message arrives
		socket.on('newMessage', function(roomId, message) {

			// No need to emit 'addMessage' to the current socket
			// As the new message will be added manually in 'main.js' file
			// socket.emit('addMessage', message);
			
			socket.broadcast.to(roomId).emit('addMessage', message);
		});

	});
}

/**
 * Initialize Socket.io
 * Uses Redis as Adapter for Socket.io
 *
 */
var init = function(app){

	var server 	= require('http').Server(app);
	var io 		= require('socket.io')(server);

	// Force Socket.io to ONLY use "websockets"; No Long Polling.
	io.set('transports', ['websocket']);

	// Using Redis
	let port = config.redis.port;
	let host = config.redis.host;
	let password = config.redis.password;
	let pubClient = redis(port, host, { auth_pass: password });
	let subClient = redis(port, host, { auth_pass: password, return_buffers: true, });
	io.adapter(adapter({ pubClient, subClient }));

	// Allow sockets to access session data
	io.use((socket, next) => {
		require('../session')(socket.request, {}, next);
	});

	// Define all Events
	ioEvents(io);

	// The server object will be then used to list to a port number
	return server;
}

module.exports = init;

1			'use strict';
2
3			var config = require('../config');
4			var redis = require('redis').createClient;
5			var adapter = require('socket.io-redis');
6
7			var Room = require('../models/room');
8
9			/**
10			* Encapsulates all code for emitting and listening to socket events
11			*
12			*/
13			var ioEvents = function(io) {
14
15			// Rooms namespace
16			io.of('/rooms').on('connection', function(socket) {
17
18			// Create a new room
19			socket.on('createRoom', function(title) {
20			Room.findOne({'title': new RegExp('^' + title + '$', 'i')}, function(err, room){
21			if(err) throw err;
			0 ignored issues – show Coding Style Best Practice introduced 2016-09-13 00:47 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
22			if(room){
23			socket.emit('updateRoomsList', { error: 'Room title already exists.' });
24			} else {
25			Room.create({
26			title: title
27			}, function(err, newRoom){
28			if(err) throw err;
			0 ignored issues – show Coding Style Best Practice introduced 2016-09-13 00:47 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
29			socket.emit('updateRoomsList', newRoom);
30			socket.broadcast.emit('updateRoomsList', newRoom);
31			});
32			}
33			});
34			});
35			});
36
37			// Chatroom namespace
38			io.of('/chatroom').on('connection', function(socket) {
39
40			// Join a chatroom
41			socket.on('join', function(roomId) {
42			Room.findById(roomId, function(err, room){
43			if(err) throw err;
			0 ignored issues – show Coding Style Best Practice introduced 2016-09-13 00:47 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
44			if(!room){
45			// Assuming that you already checked in router that chatroom exists
46			// Then, if a room doesn't exist here, return an error to inform the client-side.
47			socket.emit('updateUsersList', { error: 'Room doesnt exist.' });
48			} else {
49			// Check if user exists in the session
50			if(socket.request.session.passport == null){
51			return;
52			}
53
54			Room.addUser(room, socket, function(err, newRoom){
55
56			// Join the room channel
57			socket.join(newRoom.id);
58
59			Room.getUsers(newRoom, socket, function(err, users, cuntUserInRoom){
60			if(err) throw err;
			0 ignored issues – show Coding Style Best Practice introduced 2016-09-13 00:47 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
61
62			// Return list of all user connected to the room to the current user
63			socket.emit('updateUsersList', users, true);
64
65			// Return the current user to other connecting sockets in the room
66			// ONLY if the user wasn't connected already to the current room
67			if(cuntUserInRoom === 1){
68			socket.broadcast.to(newRoom.id).emit('updateUsersList', users[users.length - 1]);
69			}
70			});
71			});
72			}
73			});
74			});
75
76			// When a socket exits
77			socket.on('disconnect', function() {
78
79			// Check if user exists in the session
80			if(socket.request.session.passport == null){
81			return;
82			}
83
84			// Find the room to which the socket is connected to,
85			// and remove the current user + socket from this room
86			Room.removeUser(socket, function(err, room, userId, cuntUserInRoom){
87			if(err) throw err;
			0 ignored issues – show Coding Style Best Practice introduced 2016-09-13 00:47 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
88
89			// Leave the room channel
90			socket.leave(room.id);
91
92			// Return the user id ONLY if the user was connected to the current room using one socket
93			// The user id will be then used to remove the user from users list on chatroom page
94			if(cuntUserInRoom === 1){
95			socket.broadcast.to(room.id).emit('removeUser', userId);
96			}
97			});
98			});
99
100			// When a new message arrives
101			socket.on('newMessage', function(roomId, message) {
102
103			// No need to emit 'addMessage' to the current socket
104			// As the new message will be added manually in 'main.js' file
105			// socket.emit('addMessage', message);
106
107			socket.broadcast.to(roomId).emit('addMessage', message);
108			});
109
110			});
111			}
112
113			/**
114			* Initialize Socket.io
115			* Uses Redis as Adapter for Socket.io
116			*
117			*/
118			var init = function(app){
119
120			var server = require('http').Server(app);
121			var io = require('socket.io')(server);
122
123			// Force Socket.io to ONLY use "websockets"; No Long Polling.
124			io.set('transports', ['websocket']);
125
126			// Using Redis
127			let port = config.redis.port;
128			let host = config.redis.host;
129			let password = config.redis.password;
130			let pubClient = redis(port, host, { auth_pass: password });
131			let subClient = redis(port, host, { auth_pass: password, return_buffers: true, });
132			io.adapter(adapter({ pubClient, subClient }));
133
134			// Allow sockets to access session data
135			io.use((socket, next) => {
136			require('../session')(socket.request, {}, next);
137			});
138
139			// Define all Events
140			ioEvents(io);
141
142			// The server object will be then used to list to a port number
143			return server;
144			}
145
146			module.exports = init;

OmarElGabry / chat.io

index.js ➔ ioEvents B last analyzed 2017-09-14 16:19 UTC

Complexity

Size

Duplication

Importance

1 Function

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

index.js ➔ ioEvents B
last analyzed 2017-09-14 16:19 UTC